Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getContractDetails implemented for bonds #198

Merged
merged 2 commits into from
Dec 2, 2023
Merged

getContractDetails implemented for bonds #198

merged 2 commits into from
Dec 2, 2023

Conversation

rylorin
Copy link
Member

@rylorin rylorin commented Nov 29, 2023

No description provided.

}
});

test("Stock contract details", (done) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

});
});

test("Future contract details", (done) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

});
});

test("Option contract details", (done) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 3 locations. Consider refactoring.

let api: IBApiNext;
let error$: Subscription;

beforeEach(() => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

Copy link

codeclimate bot commented Nov 29, 2023

Code Climate has analyzed commit 8f67cb5 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 5

View more on Code Climate.

@rylorin rylorin merged commit 8dd6f76 into master Dec 2, 2023
1 of 2 checks passed
@rylorin rylorin deleted the bonds branch December 2, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant